Guys,
can I get a Yea or Nay for this patch?
Does it go in via Paul's gitk repo or directly through Junio?
Thanks,
Beat
On 18.07.15 13:15, Beat Bolli wrote:
> When referring to earlier commits in commit messages or other text, one
> of the established formats is
>
> <abbrev-sha> ("<summary>", <author-date>)
>
> Add a "Copy commit summary" command to the context menu that puts this
> text for the currently selected commit on the clipboard. This makes it
> easy for our users to create well-formatted commit references.
>
> The <abbrev-sha> is produced with the %h format specifier to make it
> unique. Its length can be controlled with the gitk preference
> "Auto-select SHA1 (length)", or, if this preference is set to its
> default value (40), with the Git config setting core.abbrev.
>
> Signed-off-by: Beat Bolli <[email protected]>
> Cc: Paul Mackerras <[email protected]>
> ---
> Changes since v3:
> - consider $autosellen for the --abbrev value
>
> Changes since v2:
> - call git show to produce a unique <abbrev-sha>
> - use the short date format
>
> Changes since v1:
> - drop the "commit " literal in front of the <abbrev-sha>
>
> Signed-off-by: Beat Bolli <[email protected]>
> ---
> gitk-git/gitk | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/gitk-git/gitk b/gitk-git/gitk
> index 9a2daf3..d05169a 100755
> --- a/gitk-git/gitk
> +++ b/gitk-git/gitk
> @@ -2617,6 +2617,7 @@ proc makewindow {} {
> {mc "Diff selected -> this" command {diffvssel 1}}
> {mc "Make patch" command mkpatch}
> {mc "Create tag" command mktag}
> + {mc "Copy commit summary" command copysummary}
> {mc "Write commit to file" command writecommit}
> {mc "Create new branch" command mkbranch}
> {mc "Cherry-pick this commit" command cherrypick}
> @@ -9341,6 +9342,20 @@ proc mktaggo {} {
> mktagcan
> }
>
> +proc copysummary {} {
> + global rowmenuid autosellen
> +
> + set format "%h (\"%s\", %ad)"
> + set cmd [list git show -s --pretty=format:$format --date=short]
> + if {$autosellen < 40} {
> + lappend cmd --abbrev=$autosellen
> + }
> + set summary [eval exec $cmd $rowmenuid]
> +
> + clipboard clear
> + clipboard append $summary
> +}
> +
> proc writecommit {} {
> global rowmenuid wrcomtop commitinfo wrcomcmd NS
>
>
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
