On Tue, Jul 21, 2015 at 1:57 PM, Junio C Hamano <gits...@pobox.com> wrote: > I wouldn't be surprised if such a configuration to have leftover > ".idx" files that lack ".pack" affected performance, but I think you > really have to work on getting into such a situation (unless your > operating system is very cooperative and tries hard to corrupt your > repository, that is ;-), so I wouldn't be surprised if you were the > first one to report this.
I'm inclined to believe Windows isn't helping this situation: seems like something it might do, especially because of how it behaves if one process has a file open. Since I haven't caught a case where these files show up, maybe adding some tweaks to look for it occurring (such as on our Jenkins workers, if it's happening there now) would give us a better indication of the "why" question. It could even be that it has occurred long ago, and the performance issue is just now observed: our environment has run 1.7.4, 1.8.3, and now 1.9.5 -- so even an unknown bug in a previous version could impact us now. > > We open the ".idx" file and try to keep as many of them in-core, > without opening corresponding ".pack" until the data is needed. > > When we need an object, we learn from an ".idx" file that a > particular pack ought to have a copy of it, and then attempt to open > the corresponding ".pack" file. If this fails, we do protect > ourselves from strange repositories with only ".idx" files by not > using that ".idx" and try to see if the sought-after object exists > elsewhere (and if there isn't we say "no such object", which is also > a correct thing to do). > > I however do not think that we mark the in-core structure that > corresponds to an open ".idx" file in any way when such a failure > happens. If we really cared enough, we could do so, saying "we know > there is .idx file, but do not bother looking at it again, as we > know the corresponding .pack is missing", and that would speed things > up a bit, essentially bringing us back to a sane situation without > any ".idx" without corresponding ".pack". I think this is where the performance hit occurs on Windows: file stat operations in general are pretty slow, and I know msysgit did some things to emulate as much of the POSIX API as possible -- which isn't always easy on Windows. But, some of the developers that know compat/win32/ better would know more (I recall the dirent stuff being pretty complicated, but open/fopen seem rather straightforward). And yes -- retrying the operation each time and failing only compounds the issue. > > I do not think it is worth the effort, though. It would be more > fruitful to find out how you end up with ".idx exists but not > corresponding .pack" and if that is some systemic failure, see if > there is a way to prevent that from happening in the first place. Agreed. It feels like a workaround for a case where you're already in a bad state... > > Also, I think it may not be a bad idea to teach "gc" to remove stale > ".idx" files that do not have corresponding ".pack" as garbage. I agree. This seems like a more correct solution -- if gc understands to clean up these bad .idx files, it would then be a non-issue when searching the packs. The solution you posted to check if an associated packfile exists -- while perhaps not belonging there -- could still be useful to delete orphanend .idx files. I think you're correct, though -- if you did propose the solution to sha1_file.c, it would be necessary to prevent scanning that .idx again, or else any potential gains would be lost continually stat()'ing the file. Now, msysgit does have core.fscache to try caching the stat()/lstat() results to lessen the impact, but this isn't on by default, I believe. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
