On Wed, Aug 12, 2015 at 10:53 AM, Junio C Hamano <[email protected]> wrote: > Stefan Beller <[email protected]> writes: > >> On Mon, Jun 15, 2015 at 2:48 PM, Junio C Hamano <[email protected]> wrote: >>> Thanks. Will replace and wait for comments from others. >> >> I have reviewed the patches carefully and they look good to me. > > OK, I recall there were a few iterations with review comments before > this round. Is it your impression that they have been addressed > adequately?
I payed only little attention to the previous rounds and the review comments thereof, because round 5 was up for quite a long time and nobody commented so far. However just as I was convinced of my review and sent out the email, I started working with it. And I found nits which I'd ask you to squash into the round or put on top. > > Do you prefer it to be rebased to a more recent 'master' before you > build your work on top of it (I think the topic currently builds on > top of v2.5.0-rc0~56)? Looking at the reviews for the "RFC parallel fetch for submodules" I'd like to use `argv_array_pushv` which was introduced via 85b343245b (2015-06-14, argv-array: implement argv_array_pushv()) and is already in origin/next, but not origin/master. But as I first work on the submodule--helper (both the small helper functions as well as the whole "update" thereafter), I think this dependency is not a pressing issue yet. > > Thanks. Stefan Beller (2): Fixup hv/documentation cleanup submodule_config a bit. Documentation/technical/api-submodule-config.txt | 3 +-- submodule-config.c | 12 +++++------- 2 files changed, 6 insertions(+), 9 deletions(-) -- 2.5.0.234.gefc8a62 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
