Dave Borowitz <dborow...@google.com> writes: > Slight digression for a question that came up during reworking the > series: would it be reasonable to rewrite option parsing in > builtin/send-pack.c to use the options API?
Surely. The part of the system whose option parsing predates parse-options may not have been converted to do so yet, but as long as the result is correct, why not. After all APIs were invented to be used. > That way we can easily > reuse the option callback from builtin/push.c. (It would have some > side effects like making --no-* variants work where they did not > before; I assume that's a good thing, but it's marginally inconsistent > with some other plumbing commands like receive-pack.) As long as people are not deliberately feeding --no-something and relying on it to fail, we'd be ok ;-). -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
