On Thu, Aug 20, 2015 at 12:59 PM, Matthieu Moy <matthieu....@grenoble-inp.fr> wrote: > Karthik Nayak <karthik....@gmail.com> writes: > >> Speaking of quote_value, The quote doesn't work well with color's >> for e.g. >> git for-each-ref --shell --format="%(color:green)%(refname)" >> '''refs/heads/allow-unknown-type''' >> Seems like an simple fix, probably after GSoC I'll do this :) > > Anyway, the %(color) is really meant to be displayed on-screen, and the > quoting is really meant to feed the value to another program, so I can > hardly imagine a use-case where you would want both. > > But the current behavior seems fine to me: the color escape sequence is > quoted, which is good. For example, you can > > x=$(git for-each-ref --shell --format="nocolor%(color:green)%(refname)" | > head -n 1) > sh -c "echo $x" > > it will actually display "nocolor" without color, then a green refname. > I'm not sure the quoting is really necessary, but it doesn't harm and it > makes sense since the escape sequence contains a '[' which is a shell > metacharacter. >
Thanks for explaining that! I agree with whatever you've said. -- Regards, Karthik Nayak -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
