On Tue, Aug 25, 2015 at 4:04 AM, Junio C Hamano <gits...@pobox.com> wrote: > Matthieu Moy <matthieu....@grenoble-inp.fr> writes: > >> Karthik Nayak <karthik....@gmail.com> writes: >> >>> diff --git a/Documentation/git-for-each-ref.txt >>> b/Documentation/git-for-each-ref.txt >>> index 1997657..06d468e 100644 >>> --- a/Documentation/git-for-each-ref.txt >>> +++ b/Documentation/git-for-each-ref.txt >>> @@ -133,7 +133,8 @@ align:: >>> `<position>` is either left, right or middle and `<width>` is >>> the total length of the content with alignment. If the >>> contents length is more than the width then no alignment is >>> - performed. >>> + performed. If used with '--quote' everything in between %(align:..) >>> + and %(end) is quoted. >> >> There's no --quote, there are --shell, --python, ... (well, actually, I >> would have prefered to have a single --quote=language option, but that's >> not how it is now). >> >> I had already commented on a preliminary version of this series >> off-list. I think all my previous comments have been taken into account. > > Thanks, both. I think this is pretty close to being satisfactory > ;-) There may probably be a handful of minor nits like the above > that need to be addressed, but I do not think I saw anything > glaringly wrong that makes the series unsalvageable. It was a very > pleasant read. > > It's almost there, and I am very happy to see how this and other > series evolved so far ;-)
I like how it's totally different from what I started off with, it's been a great learning curve for me. Thanks for reviews. -- Regards, Karthik Nayak -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
