On Thu, Aug 27, 2015 at 3:18 AM, Luke Diamand <[email protected]> wrote: > When importing a label which references a commit that git-p4 does > not know about, git-p4 should skip it and go on to process other > labels that can be imported. > > Instead it crashes when attempting to find the missing commit in > the git history. This test demonstrates the problem. > > Signed-off-by: Luke Diamand <[email protected]> > --- > diff --git a/t/t9811-git-p4-label-import.sh b/t/t9811-git-p4-label-import.sh > index 095238f..f7d5048 100755 > --- a/t/t9811-git-p4-label-import.sh > +++ b/t/t9811-git-p4-label-import.sh > @@ -214,6 +214,51 @@ test_expect_success 'use git config to enable > import/export of tags' ' > ) > ' > > +p4_head_revision() { > + p4 changes -m 1 "$@" | awk '{print $2}' > +} > + > +# Importing a label that references a P4 commit that has > +# has not been seen. The presence of a label on a commit
s/has has/has/ > +# we haven't seen should not cause git-p4 to fail. It should > +# merely skip that label, and still import other labels. > +test_expect_failure 'importing labels with missing revisions' ' -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
