Jeff King <p...@peff.net> writes: > Yeah, that was my thinking. Since I _did_ end up doing the cleanup and > posted it earlier, please feel free to review and express an opinion on > the original versus the cleanup. > > I'm on the fence. I do think the cleaned-up version is much nicer, but > I always worry about the risk of touching little-used code.
True. With s/strbuf_read_file()/strbuf_getline()/ on the first one I think there is no regression (at least, that is the only deliberate regression I saw). I found all other parts of the cleaned-up version much nicer, too. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
