Jonathan Lebon <jonathan.le...@gmail.com> writes: > As it is, the suggested command for trying out diff-highlight will just > dump the whole git log output to the terminal. Let's pipe it through > `less` so users aren't surprised on the first try.
That justifies the "less" part but not your choice of "-r". I am assuming that you are telling "less" not to show the ANSI "color" escape sequences using the caret notation with "-r", which is a very natural and sensible thing to do when using `highlight`. But if that is the case, you don't want "-r" (raw control chars for everything). You would want to say "-R", I think. Other than that, looks like a sensible thing to do to me. Thanks. > Signed-off-by: Jonathan Lebon <jonathan.le...@gmail.com> > --- > contrib/diff-highlight/README | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/contrib/diff-highlight/README b/contrib/diff-highlight/README > index 836b97a..bbbfdda 100644 > --- a/contrib/diff-highlight/README > +++ b/contrib/diff-highlight/README > @@ -44,9 +44,9 @@ Use > > You can try out the diff-highlight program with: > > ---------------------------------------------- > -git log -p --color | /path/to/diff-highlight > ---------------------------------------------- > +------------------------------------------------------ > +git log -p --color | /path/to/diff-highlight | less -r > +------------------------------------------------------ > > If you want to use it all the time, drop it in your $PATH and put the > following in your git configuration: -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
