On Mon, Nov 2, 2015 at 11:03 PM, David Turner <[email protected]> wrote:
> On Sun, 2015-11-01 at 14:55 +0100, Nguyễn Thái Ngọc Duy wrote:
>>
>>+#define CE_NO_WATCH (0x0001)
>
> This name seems very confusing to me. CE_NO_WATCHMAN_STAT?
> CE_UNKNOWN_TO_WATCHMAN?
Files that are known updated. Maybe CE_WATCHMAN_DIRTY?
> (one reason it may seem more confusing to me than to others is that
> Twitter's code has a concept of files that we don't watch at all e.g.
> Intellij's .idea dir).
>
>> @@ -322,6 +325,7 @@ struct index_state {
>> struct untracked_cache *untracked;
>> void *mmap;
>> size_t mmap_size;
>> + char *last_update;
>
> Might be worth a comment explaining what this is.
It's the clock value from watchman when we query file status. Will
make a note. Or maybe I should just rename it to watchman_clock.
--
Duy
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
