> + else if (seen_bits & PACKDIR_FILE_PACK && seen_bits ^
> ~PACKDIR_FILE_IDX)
as just talked about: did you mention && !(seen_bits & FILE_IDX)
>
> + if (seen_bits ==
> (PACKDIR_FILE_PACK|PACKDIR_FILE_IDX|PACKDIR_FILE_BITMAP))
> + return;
> +
> + if (seen_bits ==
> (PACKDIR_FILE_PACK|PACKDIR_FILE_IDX|PACKDIR_FILE_KEEP))
> + return;
> +
> + if (seen_bits ==
> (PACKDIR_FILE_PACK|PACKDIR_FILE_IDX|PACKDIR_FILE_BITMAP|PACKDIR_FILE_KEEP))
> + return;
I wonder if this should be rewritten as
if (seen_bits & FILE_PACK && seen_bits & FILE_IDX
&& (seen_bits & FILE_KEEP || seen_bits & BITMAP))
return;
to dense it a bit. ;)
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
