On Mon, Nov 23, 2015 at 07:04:46PM -0500, Eric Sunshine wrote:
> On Tue, Nov 17, 2015 at 5:01 PM, John Keeping <[email protected]> wrote:
> > These configuration variables specify the paths to commands so we should
> > support tilde-expansion for files inside a user's home directory.
>
> Hmm, I don't see anything in the documentation which says that these
> are paths to commands, and the code itself treats them purely as
> commands to be invoked, not as paths to commands. What is the
> behavior, for instance, with --tocmd='foobar -x zopp' or even
> --tocmd='foobar -x ~/zopp'?
The path behaviour only expands leading '~' and '~user' (as documented
in git-config(1)):
$ git -c sendemail.tocmd='foobar -x ~/zopp' config --path
sendemail.tocmd
foobar -x ~/zopp
> > Signed-off-by: John Keeping <[email protected]>
> > ---
> > diff --git a/git-send-email.perl b/git-send-email.perl
> > index 719c715..8e4c0e1 100755
> > --- a/git-send-email.perl
> > +++ b/git-send-email.perl
> > @@ -242,9 +242,7 @@ my %config_settings = (
> > "smtpdomain" => \$smtp_domain,
> > "smtpauth" => \$smtp_auth,
> > "to" => \@initial_to,
> > - "tocmd" => \$to_cmd,
> > "cc" => \@initial_cc,
> > - "cccmd" => \$cc_cmd,
> > "aliasfiletype" => \$aliasfiletype,
> > "bcc" => \@bcclist,
> > "suppresscc" => \@suppress_cc,
> > @@ -259,6 +257,8 @@ my %config_settings = (
> > my %config_path_settings = (
> > "aliasesfile" => \@alias_files,
> > "smtpsslcertpath" => \$smtp_ssl_cert_path,
> > + "tocmd" => \$to_cmd,
> > + "cccmd" => \$cc_cmd,
> > );
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
