On Thu, Dec 17, 2015 at 2:41 AM, Eric Sunshine <[email protected]> wrote: > On Wed, Dec 16, 2015 at 10:29 AM, Karthik Nayak <[email protected]> wrote: >> In upcoming patches we make calls to match_atom_name() with the '*' >> deref specifier still attached to the atom name. This causes >> undesirable errors, hence, if present skip over the '*' deref >> specifier in the atom name. > > I'd drop the second sentence since it doesn't add much or any value. > Instead, you might want to explain that skipping '*' is done as a > convenience. > > Subsequent patches will call match_atom_name() with the '*' deref > specifier still attached to the atom name so, as a convenience, > skip over it on their behalf. >
Thanks will put that in. >> Signed-off-by: Karthik Nayak <[email protected]> >> --- >> diff --git a/ref-filter.c b/ref-filter.c >> @@ -37,6 +37,10 @@ static int match_atom_name(const char *name, const char >> *atom_name, const char * >> { >> const char *body; >> >> + /* skip the deref specifier*/ > > Too many spaces before "skip". > Too few spaces after "specifier". > Will fix. -- Regards, Karthik Nayak -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
