From: Lars Schneider <[email protected]>
diff to v3:
* pass type as parameter to "git_config_from_mem" (renamed from
"git_config_from_buf") and "do_config_from_file"
* split current_config_type_name into two functions
* explain usage of fwrite with a comment
* use tabs instead of spaces to fix indentation error
* squash Peff's commit to split the test cases
* sort all test configs key/value pairs in the same way
* add comment to explain newline introduce by here-doc
* use real tabs for test file name
* add a test teardown
* fix hiding of git exit code t1300 and t7008
* drop "git-config.txt: describe '--includes' default behavior" patch
I like the idea of a "test set up block" within a test script. In order
to clean up nicely before any subsequent tests I would like to propose
a "tear down" block. Would that work as a compromise in our "test cases
depend on earlier test cases" discussion?
In "t: do not hide Git's exit code in tests" I also fixed a few more
places where Git's exit code was hidden. Please drop this patch if you
think that this should not be part of this series.
Thanks a lot for the reviews and explainations,
Lars
Lars Schneider (3):
t: do not hide Git's exit code in tests
config: add 'type' to config_source struct that identifies config type
config: add '--show-origin' option to print the origin of a config
value
Documentation/git-config.txt | 15 ++--
builtin/config.c | 33 +++++++++
cache.h | 6 +-
config.c | 36 +++++++---
submodule-config.c | 4 +-
t/t1300-repo-config.sh | 167 ++++++++++++++++++++++++++++++++++++++++++-
t/t1308-config-set.sh | 4 +-
t/t7008-grep-binary.sh | 3 +-
8 files changed, 242 insertions(+), 26 deletions(-)
--
2.5.1
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html