On Wed, Feb 24, 2016 at 8:26 PM, Johannes Schindelin <[email protected]> wrote: > Hi Duy, > > On Wed, 24 Feb 2016, Duy Nguyen wrote: > >> On Wed, Feb 24, 2016 at 01:48:11PM +0100, Johannes Schindelin wrote: >> > + die("not in a git directory"); >> >> Maybe wrap this string with _() for translation? Then we can pile this >> patch on top to fix the rest in builtin/config.c. > > Given that the context lines contain die() calls *without* _(), I would > find it more logical if your patch patched also the line I introduced, > together with the other die() calls.
No problem. I'll go over all changes in 'next' and 'pu' some time later and try to fix them all. -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
