On 26 Feb 2016, at 10:33, Duy Nguyen <pclo...@gmail.com> wrote: > On Fri, Feb 26, 2016 at 4:30 PM, Lars Schneider > <larsxschnei...@gmail.com> wrote: >> >>> On 26 Feb 2016, at 10:26, Duy Nguyen <pclo...@gmail.com> wrote: >>> >>> On Thu, Feb 25, 2016 at 3:42 PM, <larsxschnei...@gmail.com> wrote: >>>> +ifdef DEVELOPER >>>> + CFLAGS += -Werror \ >>>> + -Wdeclaration-after-statement \ >>>> + -Wno-format-zero-length \ >>>> + -Wold-style-definition \ >>>> + -Woverflow \ >>>> + -Wpointer-arith \ >>>> + -Wstrict-prototypes \ >>>> + -Wunused \ >>>> + -Wvla >>> >>> With the exception of $(SCRIPTS) in Makefile, I think we prefer to >>> avoid \ and have one addition per statement >>> >> I guessed that because I actually looked through the makefile to find how >> you deal with line >> brakes. The problem here was that this line gets really long and then it is >> hard to see what >> warnings are enabled. >> Would you be OK with using \ for readability here? > > Probably misunderstanding. I meant something like this > > CFLAGS += -Werror > CFLAGS += -Wdecl.. > CFLAGS += -Wno-form..
Oh. I just realized the patch made it already into master. Do you think I should submit a follow up patch? I also wonder, do you see an advantage of one style over the other or do you want me to change it for consistency? Thanks, Lars-- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
