Jeff King <[email protected]> writes: > On Sun, Feb 28, 2016 at 01:35:44AM +0600, Alexander Kuleshov wrote: > >> +DECLARE_GIT_GETTER(const char *, get_git_dir, git_dir) >> +DECLARE_GIT_GETTER(const char *, get_git_namespace, namespace) >> +DECLARE_GIT_GETTER(char *, get_object_directory, git_object_dir) >> +DECLARE_GIT_GETTER(char *, get_index_file, git_index_file) >> +DECLARE_GIT_GETTER(char *, get_graft_file, git_graft_file) > > Hmm. I'm somewhat lukewarm on this patch. It's fewer lines and less > duplication, which is nice, but this kind of code generation often makes > things annoying (to step into with the debugger, to find with ctags, > etc). I dunno.
For this particular set of functions, single-step-ability would not be a huge issue, but I am not enthused, either, even though these are vastly more palatable than what was originally proposed. Another minor annoyance is that I expect to see a semicolon after a pair of parentheses that follows a token, but adding one of course would break the compilation. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
