On Tue, Mar 8, 2016 at 11:34 AM, Junio C Hamano <gits...@pobox.com> wrote: > On Mon, Mar 7, 2016 at 9:41 PM, Karthik Nayak <karthik....@gmail.com> wrote: >> >> You're correct, the "handler" functions run once for each "ref". But WRT >> to the %(if)...%(then)...%(else)...%(end) atoms, it needs to be. Because >> each outcome of these atoms depend on the current outcome of the fields >> used between then WRT to the current ref. > > Yeah, there is no argument against that part at all. My comment was purely > about preparsing the if_equals field. All other fields are preparsed in > *parse() > helper functions and it looked strange that only these two are scanned in the > handle() function every time it is evaluated for each ref, only to yield the > same result.
True, I definitely agree, will fix that in the next iteration, thanks. -- Regards, Karthik Nayak -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
