Pranit Bauva <[email protected]> writes: > diff --git a/builtin/commit.c b/builtin/commit.c > index b3bd2d4..63ee0f2 100644 > --- a/builtin/commit.c > +++ b/builtin/commit.c > @@ -1310,6 +1310,10 @@ static int git_status_config(const char *k, const char > *v, void *cb) > return error(_("Invalid untracked files mode '%s'"), v); > return 0; > } > + if (!strcmp(k, "commit.verbose")) { > + verbose = git_config_bool(k, v); > + return 0; > + } > return git_diff_ui_config(k, v, NULL); > }
Checking the code flow in cmd_commit(), we first do the config, and then later call parse_options(), so it is clear that giving the initial value of 0 or 1 depending on the boolean setting would be all that is necessary to support "--no-verbose", which makes the patch very compact. Good. But doesn't this belong to git_commit_config(), not git_STATUS_config()? Should "commit.verbose" make output from "git status" verbose? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
