On Tue, Mar 15, 2016 at 12:13 PM, Alexander Kuleshov <kuleshovm...@gmail.com> wrote: > from the <hashmap.h> for simplification.
I think what Eric wanted to point out, was to not have a continuous sentence from commit message header to body. Either leave the body blank (as it is obvious) or write a whole sentence there: [PATCH v2] submodule-config: use hashmap_iter_first() The hashmap API offers the `hashmap_iter_first` function as initializing and getting the first entry is a common pattern. Use that instead of doing initialization by hand and then get the first entry. > > Signed-off-by: Alexander Kuleshov <kuleshovm...@gmail.com> > Reviewed-by: Stefan Beller <sbel...@google.com> > --- > Changelog: added missed Signof-off-by and function name fixed > in the commit message. > > submodule-config.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/submodule-config.c b/submodule-config.c > index b82d1fb..8ac5031 100644 > --- a/submodule-config.c > +++ b/submodule-config.c > @@ -405,8 +405,7 @@ static const struct submodule *config_from(struct > submodule_cache *cache, > struct hashmap_iter iter; > struct submodule_entry *entry; > > - hashmap_iter_init(&cache->for_name, &iter); > - entry = hashmap_iter_next(&iter); > + entry = hashmap_iter_first(&cache->for_name, &iter); > if (!entry) > return NULL; > return entry->config; > -- > 2.8.0.rc2.216.g1477fb2.dirty > > -- > To unsubscribe from this list: send the line "unsubscribe git" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
