On Thu, Mar 17, 2016 at 01:32:41AM -0400, Eric Sunshine wrote: > On Wed, Mar 16, 2016 at 9:43 PM, Jeff King <p...@peff.net> wrote: > > Arguably cmd_commit() should be using OPT_BOOL instead of OPT__VERBOSE, > > as there is no such thing as "verbose > 1" here. But I don't think there > > is any real user-facing consequence of that (however, given Eric's > > suggestion, I suspect it would make Pranit's problem just go away, as it > > assigns rather than increments; IOW, it does the thing Eric was > > suggestion OPT__VERBOSE to do). > > Actually, Pranit's previous version of the patch did treat verbosity > as a boolean, but then SZEDER pointed out this bit from > git-commit.txt: > > --verbose:: > ... > If specified twice, show in addition the unified diff between > what would be committed and the worktree files, i.e. the unstaged > changes to tracked files. > > which is what led us to the current discussion about wanting an > "unspecified" value for OPT__VERBOSE.
Ah, thanks. I looked for something like that in builtin/commit.c and didn't see us using verbose as anything but a boolean. But we pass it into wt_status, which does look at "s->verbose > 1". Sorry for the noise (and probably I should stop participating in this discussion without having read all of the backstory!). -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
