Am 28.03.2016 um 17:14 schrieb Johannes Schindelin:
> Hi Hannes,
>
> On Mon, 28 Mar 2016, Johannes Sixt wrote:
>
>> A change like this whould have been preferable:
>> [...]
>
> The problem with your patch is that it does not account for backslashes in
> paths resulting in quoting. I am afraid that your patch will most likely
> *not* let the tests pass in Git for Windows SDK, while my patch does.
It does pass. The reason is that pwd -W generates forward slashes.
This part of your 45bf3297 (t1300: fix the new --show-origin tests on
Windows)
@@ -1205,6 +1205,9 @@ test_expect_success POSIXPERM,PERL 'preserves existing per
"die q(badrename) if ((stat(q(.git/config)))[2] & 07777) != 0600"
'
+! test_have_prereq MINGW ||
+HOME="$(pwd)" # convert to Windows path
+
test_expect_success 'set up --show-origin tests' '
INCLUDE_DIR="$HOME/include" &&
mkdir -p "$INCLUDE_DIR" &&
is actually a much more concise version of my proposed patch,
although the result still misuses $HOME where it does not have
to. In fact, if I revert 5ca6b7bb (config --show-origin: report
paths with forward slashes), the tests still pass. But since it
does not make a difference save for a few microseconds more or
less during startup, it is not worth the churn at this point.
-- Hannes
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
