On Tue, Mar 29, 2016 at 9:29 AM, Mehul Jain <mehul.jain2...@gmail.com> wrote:
> t/t5520: change rebase.autoStash to rebase.autostash
This subject is written at too low a level, talking about details of
the patch rather than giving a high-level overview. A further
shortcoming is that there's no explanation of *why* this change is
desirable. Here's an attempt which addresses both problems.
t5520: use consistent capitalization in test titles
(Note that I dropped the leading "t/" since it's implied.)
The patch itself is fine.
> Signed-off-by: Mehul Jain <mehul.jain2...@gmail.com>
> ---
> t/t5520-pull.sh | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/t/t5520-pull.sh b/t/t5520-pull.sh
> index 745e59e..5be39df 100755
> --- a/t/t5520-pull.sh
> +++ b/t/t5520-pull.sh
> @@ -267,7 +267,7 @@ test_expect_success 'pull --rebase --autostash &
> rebase.autostash=true' '
> test "$(cat file)" = "modified again"
> '
>
> -test_expect_success 'pull --rebase --autostash & rebase.autoStash=false' '
> +test_expect_success 'pull --rebase --autostash & rebase.autostash=false' '
> test_config rebase.autostash false &&
> git reset --hard before-rebase &&
> echo dirty >new_file &&
> @@ -278,7 +278,7 @@ test_expect_success 'pull --rebase --autostash &
> rebase.autoStash=false' '
> test "$(cat file)" = "modified again"
> '
>
> -test_expect_success 'pull --rebase: --autostash & rebase.autoStash unset' '
> +test_expect_success 'pull --rebase: --autostash & rebase.autostash unset' '
> git reset --hard before-rebase &&
> echo dirty >new_file &&
> git add new_file &&
> --
> 2.7.1.340.g69eb491.dirty
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
