Jeff King <p...@peff.net> writes:
>> + if (compute_and_write_prerequisites(bundle_fd, &revs, argc, argv)) {
>> + if (!bundle_to_stdout)
>> + close(bundle_fd);
>> return -1;
>> + }
>
> Makes sense. Should we also be rolling back the lock file? It happens
> automatically at program exit, of course, but we are in library code
> here that should not rely on that.
Yeah, I agree. I suspect that the original wasn't even meant to be
used in a "library-ish" fashion, but as long as we are adding this
close(), we should also be doing the rollback.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
