On Wed, Mar 30, 2016 at 10:32:40AM -0700, Stefan Beller wrote: > > I'm OK with all of these as-is, though I did mention a nit in the third > > one. I also like Junio's rewrite instead of using strbuf_list_free. > > I'm fine using the rewritten version instead of using strbuf_list_free. :) > On the third one, there is one case, where we have > > if (..) > return error(_(text)); > > and that is an exit(128); eventually.
In the caller perhaps, but isn't that equivalent to: error(_(text)); return -1; ? I think it is OK to make assumptions about error()'s return value; that is what it is there for. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
