Stefan Beller <[email protected]> writes: > The `prefix` was put in front of the display path unconditionally. > This is wrong as any relative path computation would need to be at > the front, so include the prefix into the display path. > > The new test replicates the previous test with the difference of executing > from a sub directory. By executing from a sub directory all we would > expect all displayed paths to be prefixed by '../'. > > Prior to this patch the test would report > Entering 'nested1/nested2/../nested3' > instead of the expected > Entering '../nested1/nested2/nested3' > > Signed-off-by: Stefan Beller <[email protected]> > ---
Definitely easier to read and helps understand what is going on in the changed codepath much better. Very well done. Thanks. > diff --git a/t/t7407-submodule-foreach.sh b/t/t7407-submodule-foreach.sh > index 7ca10b8..776b349 100755 > --- a/t/t7407-submodule-foreach.sh > +++ b/t/t7407-submodule-foreach.sh > @@ -178,6 +178,26 @@ test_expect_success 'test messages from "foreach > --recursive"' ' > ' > > cat > expect <<EOF > +Entering '../nested1' > +Entering '../nested1/nested2' > +Entering '../nested1/nested2/nested3' > +Entering '../nested1/nested2/nested3/submodule' > +Entering '../sub1' > +Entering '../sub2' > +Entering '../sub3' > +EOF > + > +test_expect_success 'test messages from "foreach --recursive" from > subdirectory' ' > + ( > + cd clone2 && > + mkdir untracked && > + cd untracked && > + git submodule foreach --recursive >../../actual > + ) && > + test_i18ncmp expect actual > +' > + > +cat > expect <<EOF > nested1-nested1 > nested2-nested2 > nested3-nested3 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
