On Wed, Apr 06, 2016 at 01:53:35AM -0400, Eric Sunshine wrote: > On Tue, Apr 5, 2016 at 6:21 AM, Elia Pinto <gitter.spi...@gmail.com> wrote: > > 2016-04-01 22:25 GMT+02:00 Eric Sunshine <sunsh...@sunshineco.com>: > >> In addition to review comments by others, why are the new curl_dump() > >> and curl_trace() functions duplicated in both patches rather than > >> factored out to a shared implementation? > > > > It's right. Do you think i can use some existing file or should I > > create a new object file ? > > Peff or Junio would be more qualified to answer, but perhaps the > shared implementation could go in http.c?
Yeah. If it is linking with curl it must be in one of the objects that gets compiled only when NO_CURL is not set. Which is currently http.c, http-walker.c, and remote-curl.c. Of the three, the only one that makes sense is http.c. A new file would be OK (provided it gets added to the OBJECTS line in Makefile:1921) but I think it fits well in http.c, which is essentially our bucket of curl-related wrappers. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
