On Wed, Apr 06, 2016 at 06:58:30PM +0200, Matthieu Moy wrote: > "Michael S. Tsirkin" <m...@redhat.com> writes: > > > I have this in .git/config > > > > [trailer "r"] > > key = Reviewed-by > > command = "echo \"Michael S. Tsirkin <m...@redhat.com\"" > > [trailer "s"] > > key = Signed-off-by > > command = "echo \"Michael S. Tsirkin <m...@redhat.com\"" > > > > whenever I run git interpret-trailers -t r I see these lines added: > > > > Reviewed-by: Michael S. Tsirkin <m...@redhat.com > > Signed-off-by: Michael S. Tsirkin <m...@redhat.com > > Reviewed-by: Michael S. Tsirkin <m...@redhat.com > > > > Why is Reviewed-by repeated? Bug or feature? > > The first two lines are added unconditionally: > > $ echo | git interpret-trailers > > Reviewed-by: Michael S. Tsirkin <m...@redhat.com > Signed-off-by: Michael S. Tsirkin <m...@redhat.com > > The last line is added because you've asked for it with --trailer r. > > I don't think it's currently possible to get the behavior you seem to > expect, ie. to define trailer tokens fully (key and value) in your > config file but use them only on request. > > (BTW, I think you wanted a closing > at the end)
Is this worth fixing? It doesn't look like a behaviour anyone would want... > -- > Matthieu Moy > http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
