Hello,
On Wed, Apr 13, 2016 at 2:35 AM, Junio C Hamano <gits...@pobox.com> wrote:
> Junio C Hamano <gits...@pobox.com> writes:
>
>> Karthik Nayak <karthik....@gmail.com> writes:
>>
>>> + branch_get_color(BRANCH_COLOR_REMOTE), maxwidth,
>>> + remote_prefix,
>>> branch_get_color(BRANCH_COLOR_RESET));
>>> + } else {
>>> + strbuf_addf(&local,
>>> "%%(refname:strip=2)%s%%(if)%%(symref)%%(then) -> %%(symref:short)%%(end)",
>>> + branch_get_color(BRANCH_COLOR_RESET));
>>> + strbuf_addf(&remote,
>>> "%s%s%%(refname:strip=2)%s%%(if)%%(symref)%%(then) ->
>>> %%(symref:short)%%(end)",
>>> + branch_get_color(BRANCH_COLOR_REMOTE),
>>> remote_prefix, branch_get_color(BRANCH_COLOR_RESET));
>>
>> The overlong lines are somewhat irritating, but the change above in
>> this round relative to the previous one shows a good use case for
>> the conditional formatting feature and illustrates how powerful the
>> concept it is. I like it.
>>
>> Thanks, will queue.
They are quite long and a little confusing, but like you said really powerful.
>
> Having said that, doesn't this need to be further adjusted for
> 95c38fb0 (branch: fix shortening of non-remote symrefs, 2016-04-03)?
>
> http://thread.gmane.org/gmane.comp.version-control.git/290622/focus=290624
>
That was one of the changes made in this version of the patch series :)
--
Regards,
Karthik Nayak
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
