Johannes Schindelin <[email protected]> writes: >> >> - for (i = 0; i < list->nr; i++) >> - if (!cmp(string, list->items[i].string)) >> - return list->items + i; >> + for_each_string_list_item(item, list) { >> + if (!cmp(string, item->string)) >> + return item; >> + } >> return NULL; > > If you drop the extra curly braces (thereby matching Git's coding style as > an additional bonus), at least the patch won't increase the number of > lines. >
Oops. I'll send a new version of the patch without these extra curly braces. Thanks! > In any case, I like the simplification of the code. > > Ciao, > Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
