On Thu, Apr 28, 2016 at 08:05:04AM -0400, Jeff King wrote: > So AFAICT 14111fc49 is totally broken. It doesn't actually work for > git-submodule (because of the missing export), nor for git-fetch > (because that skips the shell script), and the one case we are testing > already worked without it (but probably _should_ be sanitizing the > config, so is buggy, too).
This last bit is not quite accurate. The test in t5550 doesn't pass without 14111fc49. But it _does_ pass if we make sanitize_submodule_env() in the shell script a noop. That's because it is going through clone_submodule() in the C code, which uses the C-only prepare_submodule_repo_env(). So that case _is_ correct right now. It's just that t5550 isn't testing the shell script part, which is broken. Probably running "git submodule update" in the resulting clone would cover that. And for the fetch case, we probably just need to be calling prepare_submodule_repo_env() there, too. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
