On Fri, 2016-04-29 at 16:34 -0700, Stefan Beller wrote:
> +test_expect_success 'fetch-pack with protocol version 2' '
> +     test_when_finished "rm -rf repo1" &&
> +     mkdir repo1 &&
> +     (
> +             cd repo1 &&
> +             git init &&
> +             test_commit 1 &&
> +             test_commit 2 &&
> +             test_commit 3 &&
> +             echo "$(git rev-parse master) refs/heads/master"
> >expected &&
> +             mkdir repo2 &&
> +             (
> +                     cd repo2 &&
> +                     git init &&
> +                     git fetch-pack --transport-version=2 -
> -upload-pack=git-upload-pack-2 ../.git refs/heads/master >../actual
> +             ) &&
> +             test_cmp expected actual
> +     )
> +'

This doesn't actually test that protocol v2 is in fact used (it just
tests that --transport-version=2 doesn't crash).  It would be nice to
actually test the version in-use.

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to