Torsten Bögershausen <[email protected]> writes: > On 2016-05-03 10.50, Mike Hommey wrote: >> While it is not strictly necessary, it makes the connect code simpler >> when there is user. >> > > That commit message does't tell too much, I think.
"Doesn't tell too much" is not necessarily bad, but "tells too little" is, and I think this tells me enough to say it is not a good change ;-) > Besides that, I'm sure it will break (at least) my ssh wrapper scripts, > which rely on user@host to be passed into the script. Thanks for bringing it up. "By reducing the language we accept it makes my coding simpler" is not a good excuse to break existing users, and "While it is not strictly necessary, " is a good hint that the author _knows_ that the change can either (1) be done without, or (2) be done in a way that does not break existing users and yet make the end result easier to read. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
