Richard Braun <[email protected]> writes:
> Signed-off-by: Richard Braun <[email protected]>
> ---
Could you justify your change with a bit more than "fix"? That is,
gitweb, when used with PATH_INFO, shows a link to parent diff
like [fill in the blank]. However, it is wrong because [fill in
the blank].
Make it show it like [fill in the blank]. Because [fill in the
blank], delete 'hash_parent' element from the %params hash once
we used it; otherwise [fill in the blank to describe "this bad
thing happens"].
or something like that.
Thanks.
> gitweb/gitweb.perl | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index 05d7910..f7f7936 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -1423,7 +1423,12 @@ sub href {
> delete $params{'hash'};
> delete $params{'hash_base'};
> } elsif (defined $params{'hash'}) {
> - $href .= esc_path_info($params{'hash'});
> + if (defined $params{'hash_parent'}) {
> + $href .= esc_path_info($params{'hash_parent'});
> + delete $params{'hash_parent'};
> + } else {
> + $href .= esc_path_info($params{'hash'});
> + }
> delete $params{'hash'};
> }
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
