On Mon, May 09, 2016 at 11:36:09AM -0700, Junio C Hamano wrote: > Junio C Hamano <gits...@pobox.com> writes: > > > Yes, I think the comment should just go. Nobody used that alphabet > > form since it was written in d17cf5f3 (tests: Introduce test_seq, > > 2012-08-04). > > > >> I don't really care either way whether it is replaced or not (at one > >> point there were some people really interested in NO_PERL not even using > >> one-liners in the test suite, but I am not one of them). > > > > Neither am I, but I think it is prudent to drop that "letters". The > > comment even says the letter form is not portable already, so the > > mention of GNU seq(1) is not helping at all. > > -- >8 -- > Subject: test-lib-functions.sh: remove misleading comment on test_seq
Thanks, this (and the actual implementation change) both look good to me, and I'm happy with either or both being applied. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
