On Thu, May 12, 2016 at 9:28 PM, Junio C Hamano <[email protected]> wrote: > Christian Couder <[email protected]> writes: > >> To libify the apply functionality the 'unidiff_zero' variable should >> not be static and global to the file. Let's move it into >> 'struct apply_state'. >> >> Reviewed-by: Stefan Beller <[email protected]> >> Signed-off-by: Christian Couder <[email protected]> >> --- > > Looks correct; I would have expected from the flow of thought in the > series that p_value and linenr that were already mentioned would be > the first two to be put in this, but that would have to wait until > more functions are taught to pass the state around, so this ordering > would probably be fine.
Yeah, if the patches that put p_value and linenr into 'struct apply_state' were earlier in the series, they would have to pass the state around to a lot more functions, so they would have been very big. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
