Hi Junio, On Tue, 10 May 2016, Junio C Hamano wrote:
> Johannes Schindelin <[email protected]> writes: > > > On Fri, 6 May 2016, Junio C Hamano wrote: > > > > 2) I was under the impression that we preferred test_i18ngrep over grep... > > Only when the strings we are expecting are subject to i18n. I > somehow did not think your report() codepath has any i18n/l10n? I finally remembered why I thought that test_i18ngrep was to be preferred over grep. For years, Git for Windows carried a patch that introduced a special `cmp` for use with text files, so that differences in the end-of-line markers could be ignored. IIRC we abandoned this when test_i18ncmp learned to perform this trick. Only that it really is test_cmp that learned this trick... so I was wrong. So please forget what I said about this part of the patch. Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
