Hi Mehul, Mehul Jain <mehul.jain2...@gmail.com> writes: > People may want to always use "--show-signature" while using "git log" > or "git show". > > When log.showsignature set true, "git log" and "git show" will behave
'When log.showsignature is set to true' ? > as "--show-signature" was given to them. s/as/as if > Signed-off-by: Mehul Jain <mehul.jain2...@gmail.com> > --- > Documentation/git-log.txt | 4 ++++ > builtin/log.c | 6 ++++++ > t/t4202-log.sh | 19 +++++++++++++++++++ > t/t7510-signed-commit.sh | 7 +++++++ > 4 files changed, 36 insertions(+) > [...] > [...] > +test_expect_success GPG 'log.showsignature=true behaves like > --show-signature' ' > + git checkout -b test_sign master && > + echo foo >foo && > + git add foo && > + git commit -S -m signed_commit && > + test_config log.showsignature true && > + git log -1 signed >actual && > + test_i18ngrep "gpg: Signature made" actual && > + test_i18ngrep "gpg: Good signature" actual > +' > + > +test_expect_success GPG '--show-signature overrides log.showsignature=false' > ' > + test_when_finished "git reset --hard && git checkout master" && > + git config log.showsignature false && Any specific reason as to why you don't use test_config like in the first test? > + git log -1 --show-signature signed >actual && > + test_i18ngrep "gpg: Signature made" actual && > + test_i18ngrep "gpg: Good signature" actual > +' > + > test_expect_success 'log --graph --no-walk is forbidden' ' > test_must_fail git log --graph --no-walk > ' > diff --git a/t/t7510-signed-commit.sh b/t/t7510-signed-commit.sh > index 4177a86..326dcc8 100755 > --- a/t/t7510-signed-commit.sh > +++ b/t/t7510-signed-commit.sh > @@ -210,4 +210,11 @@ test_expect_success GPG 'show lack of signature with > custom format' ' > test_cmp expect actual > ' > > +test_expect_success GPG 'log.showsignature behaves like --show-signature' ' > + git config log.showsignature true && Same here. > + git show initial > actual && Style: no space after redirection. Thanks, Rémi -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
