On 31/05/16 23:53, Junio C Hamano wrote:
> One-shot assignment to an environment variable, i.e.
>
> VAR=VAL cmd
>
> does not work as expected for "cmd" that is a shell function on
> certain shells. test_commit _is_ a helper function and cannot be
> driven that way portably.
>
> Signed-off-by: Junio C Hamano <gits...@pobox.com>
> ---
> t/t4014-format-patch.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh
> index 8049cad..c3aa543 100755
> --- a/t/t4014-format-patch.sh
> +++ b/t/t4014-format-patch.sh
> @@ -1072,7 +1072,7 @@ test_expect_success '--from omits redundant in-body
> header' '
> '
>
> test_expect_success 'in-body headers trigger content encoding' '
> - GIT_AUTHOR_NAME="éxötìc" test_commit exotic &&
> + (export GIT_AUTHOR_NAME="éxötìc"; test_commit exotic) &&
Isn't 'export VAR=VAL' non-portable? So, maybe:
(GIT_AUTHOR_NAME="éxötìc"; export GIT_AUTHOR_NAME; test_commit exotic)
&&
> test_when_finished "git reset --hard HEAD^" &&
> git format-patch -1 --stdout --from >patch &&
> cat >expect <<-\EOF &&
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
