On Thu, Jun 9, 2016 at 5:33 PM, Eric Sunshine <[email protected]> wrote: > On Wed, Jun 8, 2016 at 11:24 AM, Pranit Bauva <[email protected]> wrote: >> + strbuf_trim(&actual_hex); >> + return !strcmp(actual_hex.buf, expected_hex); > > Thus, it only ever gets to this point if the file exists but is empty, > which is very unlikely to match 'expected_hex'. I could understand it > if you checked the result of strbuf_read_file() with <0 or even <=0, > but the current code doesn't make sense to me.
By the way, this is also leaking strbuf 'actual_hex'. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
