On Wed, Jun 15, 2016 at 5:39 PM, Brian Lalor <bla...@bravo5.org> wrote: > I’m very happy to see the new compaction heuristic option; it’s the way I > always thought diffs should read! > > The config option in the documentation references “diff.compactionHeuristic”, > but diff.c does a case-sensitive comparison on “diff.compactionheuristic” > (note the case of the “h” in “heuristic”)
I think this misled you. All configuration variable names are lower-cased before they reach that strcmp() call, the whole picture is more like strcmp(tolower(var), "diff.compactionheuristic"), which I believe is correct. > and `git diff` does not honor the config. Confusingly, `git config > diff.compactionheuristic` returns true when diff.compactionHeuristic is set > in ~/.gitconfig. When diff.compactionheuristic is set to true in > ~/.gitconfig, the desired behavior is achieved. > > Thank you all for Git: it’s hard to remember the terrible world we lived in > before it existed. :-) -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
