On Thu, Jun 23, 2016 at 12:02 PM, Junio C Hamano <gits...@pobox.com> wrote: > Mehul Jain <mehul.jain2...@gmail.com> writes: > >> In patch 2/3 and 3/3, there are many tests which requires a branch >> similar to that of "signed" branch, i.e. a branch with a commit having >> GPG signature. So previously in v2, I created two new branches, >> "test_sign" and "no_sign", which are identical to that of "signed" >> branch. And with these branches, I wrote the tests in patch 2/3 >> and 3/3. >> >> As suggested by Eric [1], rather than creating new branches, I >> can take advantage of "signed" branch which already exists. > > Yeah, I understand that part. But you do not _need_ to do the split > you do in 1/3 in order to reuse "signed".
If it's fine, then I think it would be OK to drop this 1/3. Without splitting the 'log --graph --show-signature' in two test will also serve the purpose for the new test to use the signed branch. Should I send a new patch series with 1/3 dropped or you can do it manually at your end? Thanks, Mehul -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
