Hi Peff, Jeff King <[email protected]> writes: > @@ -413,7 +411,7 @@ static int write_tar_archive(const struct archiver *ar, > { > int err = 0; > > - err = write_global_extended_header(args); > + write_global_extended_header(args); > if (!err) > err = write_archive_entries(args, write_tar_entry);
If we drop the error code from 'write_global_extended_header' then the above 'if (!err)' becomes useless (always evaluates to 'true' since 'err' is set to '0'). > if (!err) Thanks, Rémi -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
