Johannes Schindelin <[email protected]> writes:
> When trying to match a pattern in the commit subject, simply skip leading
> blank lines in the commit message. This is consistent with the
> pretty-printing machinery: it silently ignores leading blank lines in the
> commit object's body.
>
> Signed-off-by: Johannes Schindelin <[email protected]>
> ---
Hmm.
I just tried
$ git commit -s -m ' pull: fast-forward "pull --rebase=true"'
expecting that ":/^ pull:" would find it ;-)
The point of this patch is to make it not work, of course, which
may or may not be a good thing. I'd rather keep this separate from
the other fixes.
Also 4/5 is another different class of true bugfix, I would suspect,
so let's take it on a separate topic that can be merged down to
older maintainance tracks.
Thanks.
> sha1_name.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/sha1_name.c b/sha1_name.c
> index ca7ddd6..da354a5 100644
> --- a/sha1_name.c
> +++ b/sha1_name.c
> @@ -912,7 +912,8 @@ static int get_sha1_oneline(const char *prefix, unsigned
> char *sha1,
> continue;
> buf = get_commit_buffer(commit, NULL);
> p = strstr(buf, "\n\n");
> - matches = negative ^ (p && !regexec(®ex, p + 2, 0, NULL, 0));
> + matches = negative ^ (p && !regexec(®ex,
> + skip_blank_lines(p + 2), 0, NULL, 0));
> unuse_commit_buffer(commit, buf);
>
> if (matches) {
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
