On Tue, Jul 19, 2016 at 12:15 PM, Junio C Hamano <gits...@pobox.com> wrote: > René Scharfe <l....@web.de> writes: > >> Use a string constant instead of an empty strbuf to shorten the code >> and make it easier to read. >> >> Signed-off-by: Rene Scharfe <l....@web.de> >> --- >> ... unless someone can come up with a suitable non-empty string to feed >> to git_config_from_mem() as its name parameter.
Thanks! > I wondered if we used to do something useful with rev and later that > useful thing was removed leaving an always-empty strbuf, but it > appears that this strbuf was introduced to always hold an empty > string and nothing else, which shows the (lack of) quality of > reviews in this area X-<. I am to blame for this. :( > > Will apply. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
