Vasco Almeida <[email protected]> writes:

> Unfold the message into several templates for each known origin_type.
> That would result in better translation at the expense of code
> verbosity.

Looks good now, except one minor nit I'll tweak out while queuing.

>       if (cf->die_on_error)
> -             die(_("bad config line %d in %s %s"), cf->linenr, 
> cf->origin_type, cf->name);
> +             die("%s", error_msg);
>       else
> -             return error(_("bad config line %d in %s %s"), cf->linenr, 
> cf->origin_type, cf->name);
> +             error_return =  error("%s", error_msg);

s/ =  / = /;

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to