On Sat, Jul 30, 2016 at 11:12:46AM -0700, Josh Triplett wrote: > > These tests follow a different style from the "--from" tests later in > > the script (and your second patch does follow it, and puts its test > > close there). Any reason not to have all of the "from" tests together, > > and using the same style? > > The tests covered different things. The later --from tests made sure > that --from behaved as expected. These tests made sure that format.from > and --from/--no-from interacted in the expected way, with the > command-line options overriding the configuration. So, I put them next > to the tests for other options like format.to and format.cc, which > tested the same thing (overriding those with --no-to, --no-cc, etc).
OK. I would have grouped by "things that influence this area of behavior", not by "config versus command-line". But I don't think either is wrong or right. And since you are the one writing the patch, "how I would have done it" is not a compelling review comment. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
