Em Wed, 03 Aug 2016 00:17:10 +0200 Florian Mickler <[email protected]> escreveu:
> cc'd [email protected] (Mauro, is your kernel.org address up?) Yes, my kernel.org address is up. Better to keep it as the canonical address, as this is unlikely to change as it is not associated to an e-mail provider. > > Am Tue, 02 Aug 2016 09:36:21 -0700 > schrieb Joe Perches <[email protected]>: > > > Hello Florian. > > > > There is at least an oddity with get_maintainer handling of a > > .mailmap entry form. > > > > For instance: > > > > Mauro's .mailmap entry is: > > Mauro Carvalho Chehab <[email protected]> <[email protected]> > > <[email protected]> <[email protected]> <[email protected]> > > <[email protected]> <[email protected]> > > > > Is this a valid form? > > > > get_maintainer output for Mauro is: > > > > $ ./scripts/get_maintainer.pl drivers/media/ -f > > Mauro Carvalho Chehab <[email protected]> <[email protected]> > > <[email protected]> <[email protected]> <[email protected]> > > <[email protected]> (maintainer:MEDIA INPUT INFRASTRUCTURE > > (V4L/DVB)) > > > > I believe the Mauro's and Shuah's .mailmap entries are improper and > > should be changed, but I'm not completely aware of git .mailmap > > handling and the documentation seems weakly specified. > > > > Hmm.. looking at Mauros last .mailmap commit it seems like your patch is > ok for Mauro. > > Although <[email protected]> and <[email protected]> are probably > missing? (@Mauro) The [email protected] is indeed an old email that I used on my first submissions. I don't know a [email protected] address... that looks really weird on my eyes... Hmm... $ git log --author "[email protected]" commit fe8b671306c78a963934cb5d6e354178390b8c87 Author: Mauro Carvalho Chehab <[email protected]> Date: Thu Sep 30 14:46:47 2010 -0300 [media] saa7134: port Asus P7131 Hybrid to use the new rc-core The rc map table were corrected thanks to Giorgio input and tests. Reported-by: Giorgio Vazzana <[email protected]> Tested-by: Giorgio Vazzana <[email protected]> Signed-off-by: Mauro Carvalho Chehab <[email protected]> I don't remember the dirty details about such patch anymore... too many years ago. From the custody chain, I _suspect_ that Giorgio proposed a patch to be applied against the saa7134 driver, but the remote controller map table was moved to a separate file about 7 months before such patch by those changesets: 6686fa6917ca V4L/DVB: Break Remote Controller keymaps into modules 77b7422d48cd V4L/DVB: ir-common: move IR tables from ir-keymaps.c to a separate file I likely rewrote his patch against the new driver, but somehow I mangled with the author name/email. In any case, [email protected] should not be associated with me. > <snip console research ... > > $ git shortlog | grep "^Mauro C" > Mauro Carvalho Chehab (4404): > $ git log | grep "^Author:.*Mauro Carvalho Chehab" | sort | uniq -c > 2 Author: Mauro Carvalho Chehab <[email protected]> > 146 Author: Mauro Carvalho Chehab <[email protected]> > 645 Author: Mauro Carvalho Chehab <[email protected]> > 794 Author: Mauro Carvalho Chehab <[email protected]> > 2015 Author: Mauro Carvalho Chehab <[email protected]> > 448 Author: Mauro Carvalho Chehab <[email protected]> > 353 Author: Mauro Carvalho Chehab <[email protected]> All above are my e-mails. Let's point them all to [email protected]. > 1 Author: Mauro Carvalho Chehab <[email protected]> This one is mangled and doesn't belong to me. So, it shouldn't be at the .mailmap file. > </snip> > > > Anyway, from a technical viewpoint your patches seem to fix > the .mailmap entry as the author intended. (See Junio's Email for the > documantation part) > But I would wait for the ack from Mauro and Shuah. With the above changes, Acked-by: Mauro Carvalho Chehab <[email protected]> Thanks, Mauro -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
