Havret commented on a change in pull request #18:
URL: 
https://github.com/apache/activemq-nms-openwire/pull/18#discussion_r795218724



##########
File path: src/Transport/FutureResponse.cs
##########
@@ -25,8 +26,13 @@ namespace Apache.NMS.ActiveMQ.Transport
        /// <summary>
        /// Handles asynchronous responses
        /// </summary>
-       public class FutureResponse
+       public class FutureResponse : TaskCompletionSource<Response>

Review comment:
       So it seems you have 2 `TCS`s to handle a single request-reply. One 
should be enough. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to