jbertram commented on code in PR #4186: URL: https://github.com/apache/activemq-artemis/pull/4186#discussion_r955297993
########## artemis-core-client/src/main/java/org/apache/activemq/artemis/spi/core/protocol/RemotingConnection.java: ########## @@ -35,9 +35,11 @@ /** * A RemotingConnection is a connection between a client and a server. * - * * Perhaps a better name for this class now would be ProtocolConnection as this * represents the link with the used protocol + * + * A default noop implementation is provided. This, for example, makes test + * implementations much simpler. Review Comment: Nice call. I implemented your suggestion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
